Efedotov/2025 03 01 terraform azure rm for adbs cross region disaster recovery by evgeniifedotov · Pull Request #30167 · hashicorp/terraform-provider-azurerm

evgeniifedotov · 2025-07-16T22:45:27Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

To support new Oracle resource type Cross Region Disaster Recovery Autonomous Database the following changes have been made to the Oracle provider: added new resource oracle_autonomous_database_cross_region_disaster_recovery_resource and corresponding data source oracle_autonomous_database_cross_region_disaster_recovery_data_source

New resource oracle_autonomous_database_cross_region_disaster_recovery_resource has following required arguments:

name,
display_name,
location,
database_type,
source,
source_id,
source_ocid,
remote_disaster_recovery_type,
replicate_automatic_backups,
subnet_id,
virtual_network_id,
resource_group_name,
source_location,
license_model,
backup_retention_period_in_days,
auto_scaling_enabled,
auto_scaling_for_storage_enabled,
mtls_connection_required,
data_storage_size_in_tbs,
compute_model,
compute_count,
db_workload,
db_version,
admin_password,
character_set,
national_character_set

New data source oracle_autonomous_database_cross_region_disaster_recovery_data_source has following attributes:

The following arguments are supported:

name - (Required) The name of this Autonomous Database.
resource_group_name - (Required) The name of the Resource Group where the Autonomous Database exists.

Attributes Reference

In addition to the Arguments listed above - the following Attributes are exported:

actual_used_data_storage_size_in_tbs - The current amount of storage in use for user and system data, in terabytes (TB).
allocated_storage_size_in_tbs - The amount of storage currently allocated for the database tables and billed for, rounded up. When auto-scaling is not enabled, this value is equal to the dataStorageSizeInTBs value. You can compare this value to the actualUsedDataStorageSizeInTBs value to determine if a manual shrink operation is appropriate for your allocated storage.
auto_scaling_enabled - Indicates if auto scaling is enabled for the Cross Region Disaster Recovery Autonomous Database CPU core count.
auto_scaling_for_storage_enabled - Indicates if auto scaling is enabled for the Cross Region Disaster Recovery Autonomous Database storage.
backup_retention_period_in_days - Retention period, in days, for backups.
character_set - The character set for the Cross Region Disaster Recovery Autonomous Database.
compute_count - The compute amount (CPUs) available to the cross region disaster recovery database.
compute_model - The compute model of the Cross Region Disaster Recovery Autonomous Database.
database_type - The type of this Cross Region Disaster Recovery Autonomous Database.
db_workload - The Autonomous Database workload type. The following values are possible:
- OLTP - indicates an Autonomous Transaction Processing database
- DW - indicates an Autonomous Data Warehouse database
- AJD - indicates an Autonomous JSON Database
- APEX - indicates an Autonomous Database with the Oracle APEX Application Development workload type.
display_name - The user-friendly name for the Cross Region Disaster Recovery Autonomous Database. The name does not have to be unique.
id - The Immutable Azure Resource ID of the Cross Region Disaster Recovery Autonomous Database.
license_model - The Oracle license model that applies to the Oracle Cross Region Disaster Recovery Autonomous Database.
lifecycle_details - Information about the current lifecycle state.
local_data_guard_enabled - Indicates whether the Cross Region Disaster Recovery Autonomous Database has local (in-region) Data Guard enabled. Not applicable to cross-region Autonomous Data Guard associations, or to Autonomous Databases using dedicated Exadata infrastructure or Exadata Cloud@Customer infrastructure.
location - The Azure Region where the Cross Region Disaster Recovery Autonomous Database exists.
mtls_connection_required - Specifies if the Cross Region Disaster Recovery Autonomous Database requires mTLS connections.
name - The name of this Cross Region Disaster Recovery Autonomous Database.
national_character_set - The national character set for the Cross Region Disaster Recovery Autonomous Database. The default is AL16UTF16. Allowed values are: AL16UTF16 or UTF8.
oci_url - The URL of the resource in the OCI console.
ocid - The OCID of the autonomous database.
peer_db_ids - The list of Immutable Azure Resource IDs of Autonomous Databases peered with this Cross Region Disaster Recovery Autonomous Database.
private_endpoint - The private endpoint for the resource.
private_endpoint_ip - The private endpoint Ip address for the resource.
private_endpoint_label - The private endpoint label for the resource.
remote_data_guard_enabled - Indicates whether the Cross Region Disaster Recovery Autonomous Database has Cross Region Data Guard enabled. Not applicable to Autonomous Databases using dedicated Exadata infrastructure or Exadata Cloud@Customer infrastructure.
remote_disaster_recovery_type - Type of recovery. Value can be either Adg (Autonomous Data Guard) or BackupBased.
replicate_automatic_backups - If true, 7 days worth of backups are replicated across regions for Cross-Region ADB or Backup-Based Disaster Recovery between Primary and Standby. If false, the backups taken on the Primary are not replicated to the Standby database.
source - The source of the database. For cross region disaster recovery autonomous database the source is always "CrossRegionDisasterRecovery" as this type of autonomous database can be created only as disaster recovery solution for another autonomous database.
source_id - The Immutable Azure Resource ID of autonomous database for which cross region disaster recovery autonomous database was created.
source_location - The Azure Region where source autonomous database for which cross region disaster recovery autonomous database is located
source_ocid - The OCID of the autonomous database for which cross region disaster recovery autonomous database was created.
subnet_id - The OCID of the subnet the resource is associated with.
supported_regions_to_clone_to - The list of regions that support the creation Cross Region Disaster Recovery clone. List is always empty as Cross Region Disaster Recovery Autonomous Database cannot be cloned.
time_created - The date and time the Autonomous Database was created.
time_data_guard_role_changed - The date and time the Autonomous Data Guard role was switched for the Cross Region Disaster Recovery Autonomous Database. For databases that have standbys in both the primary Data Guard region and a remote Data Guard standby region, this is the latest timestamp of either the database using the "primary" role in the primary Data Guard region, or database located in the remote Data Guard standby region.
time_maintenance_begin - The date and time when maintenance will begin.
time_maintenance_end - The date and time when maintenance will end.
virtual_network_id - The ID to an Azure Resource Manager vnet resource.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass.
Cross Region Disaster Recovery Autonomous Database cannot be imported. admin_password parameter is required, but this parameter cannot be imported, therefore the entire import procedure and 'requiresImport' test method cannot be executed.
Cross Region Disaster Recovery Autonomous Database cannot itself be updated as is must have exactly same parameters as peered original Autonomous Database. Updating original Autonomous Database will trigger an update for peered Cross Region Disaster Recovery Autonomous Database, therefore update test cannot be executed.

Complete test to create new instance is passing

DataSource test is passing

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

oracle_autonomous_database_cross_region_disaster_recovery_resource - support for the new Oracle Cross Region Disaster Recovery Autonomous Database resource
oracle_autonomous_database_cross_region_disaster_recovery_data_source - support for the new Oracle Cross Region Disaster Recovery Autonomous Database data source

This is a (please select all that apply):

New Feature (ie adding a service, resource, or data source)

Related Issue(s)

Fixes #30166

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

catriona-m

Hi @evgeniifedotov - it looks like there are some build failures on this, if those could be fixed up, then I can take another look. Thanks!

catriona-m

Thanks @evgeniifedotov - could you take a look at resolving the conflicts on this pr? Then we can give this a proper review. Thanks!

evgenwk · 2025-08-07T16:05:01Z

@catriona-m The conflicts have been resolved. Could you please comment? Thank you.

mihretkidane-OCI · 2025-08-22T16:20:21Z

@ms-henglu please help review this PR.

ms-henglu

Thanks for the PR, I left some comments, please check.

ms-henglu · 2025-08-25T02:43:31Z

+}
+
+func (AutonomousDatabaseCrossRegionDisasterRecoveryResource) ModelObject() interface{} {
+	return &AutonomousDatabaseCrossRegionDisasterRecoveryResource{}


It should return "&AutonomousDatabaseCrossRegionDisasterRecoveryResourceModel{}"

Typed resources must return the model struct; returning the resource struct will break decode/encode.

ms-henglu · 2025-08-25T02:45:34Z

+
+			var model AutonomousDatabaseCrossRegionDisasterRecoveryResourceModel
+			if err := metadata.Decode(&model); err != nil {
+				return err


Wrap decode error instead of returning raw:
return fmt.Errorf("decoding: %+v", err)

ms-henglu · 2025-08-25T02:46:04Z

+
+			var model AutonomousDatabaseCrossRegionDisasterRecoveryResourceModel
+			if err = metadata.Decode(&model); err != nil {
+				return fmt.Errorf("decoding err: %+v", err)


return fmt.Errorf("decoding: %+v", err)

ms-henglu · 2025-08-25T02:46:31Z

+
+			err = client.UpdateThenPoll(ctx, *id, *update)
+			if err != nil {
+				return fmt.Errorf("updating %s: %v", id, err)


use %+v not %v:
return fmt.Errorf("updating %s: %+v", id, err)

ms-henglu · 2025-08-25T02:48:50Z

+		Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
+			id, err := autonomousdatabases.ParseAutonomousDatabaseID(metadata.ResourceData.Id())
+			if err != nil {
+				return fmt.Errorf("retrieving %s: %+v", id, err)


avoid referencing id when parsing fails; include the raw ID instead:

return fmt.Errorf("parsing %q: %+v", metadata.ResourceData.Id(), err)

ms-henglu · 2025-08-25T03:02:45Z

+---
+subcategory: "Oracle"
+layout: "azurerm"
+page_title: "Azure Resource Manager: Data Source: azurerm_oracle_autonomous_database"


The title should be "azurerm_oracle_autonomous_database_cross_region_disaster_recovery"

ms-henglu · 2025-08-25T03:03:00Z

+layout: "azurerm"
+page_title: "Azure Resource Manager: Data Source: azurerm_oracle_autonomous_database"
+description: |-
+  Gets information about an existing Autonomous Database.


The description should be "Gets information about an existing Cross Region Disaster Recovery Autonomous Database."

ms-henglu · 2025-08-25T03:04:12Z

+  source_id                           = azurerm_oracle_autonomous_database_cross_region_disaster_recovery.adbs_secondary_crdr.source_id
+  source_ocid                         = azurerm_oracle_autonomous_database_cross_region_disaster_recovery.adbs_secondary_crdr.source_ocid
+  remote_disaster_recovery_type       = azurerm_oracle_autonomous_database_cross_region_disaster_recovery.adbs_secondary_crdr.remote_disaster_recovery_type
+  replicate_automatic_backups_enabled = azurerm_oracle_autonomous_database_cross_region_disaster_recovery.adbs_secondary_crdr.replicate_automatic_backups


I think it shoud be:

replicate_automatic_backups_enabled = azurerm_oracle_autonomous_database_cross_region_disaster_recovery.adbs_secondary_crdr.replicate_automatic_backups_enabled

ms-henglu · 2025-08-25T03:05:01Z

+## Example Usage
+
+```hcl
+resource "azurerm_oracle_autonomous_database_cross_region_disaster_recovery" "adbs_secondary_crdr" {


Would you please use a complete example here instead of using the placeholders.

ms-henglu · 2025-08-25T03:05:42Z

+			Type:     pluginsdk.TypeBool,
+			Computed: true,
+		},
+		"database_type": {


I think we don't need to expose all the readonly fields, maybe just the fields that could be referenced by other resources.

mihretkidane-OCI · 2025-09-08T18:08:59Z

@ms-henglu I have addressed the latest comments . Could you please check?

ms-henglu · 2025-09-10T07:57:49Z

 func (AutonomousDatabaseRegularResource) Attributes() map[string]*pluginsdk.Schema {
-	return map[string]*pluginsdk.Schema{}
+	return map[string]*pluginsdk.Schema{
+		"ocid": {


Please also update this change in the document.

This is not resolved yet

This comment is still not resolved, the documentation for azurerm_oracle_autonomous_database doesn't include this attribute

removed this attribute as its not needed to be in the resource file .

ms-henglu · 2025-09-10T08:40:05Z

+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: validate.AdbsComputeModel,


For properties which have a set of allowed values, please update the validate func like below:

ValidateFunc: validation.StringInSlice(autonomousdatabases.PossibleValuesForComputeModel(), false),

ms-henglu · 2025-09-10T08:42:28Z

+			Type:     pluginsdk.TypeString,
+			Required: true,
+			ForceNew: true,
+			ValidateFunc: validation.StringInSlice([]string{


Please update this to

ValidateFunc: validation.StringInSlice(autonomousdatabases.PossibleValuesForWorkloadType(), false),

But I also noticed that PossibleValuesForWorkloadType contain "AJD" and "APEX", can these values be used here?

ms-henglu · 2025-09-10T08:43:13Z

+			Type:     pluginsdk.TypeString,
+			Required: true,
+			ForceNew: true,
+			ValidateFunc: validation.StringInSlice([]string{


Same here.

ValidateFunc: validation.StringInSlice(autonomousdatabases.PossibleValuesForLicenseModel(), false),

ms-henglu · 2025-09-10T08:46:32Z

+	r := AdbsCrossRegionDisasterRecoveryResource{}
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.requiresImport(data),


For the import testcase, the first step should use the basic configuration to set up the resource.

ms-henglu · 2025-09-10T08:50:44Z

+			Type:         pluginsdk.TypeString,
+			Required:     true,
+			ForceNew:     true,
+			ValidateFunc: validate.DatabaseType,


Please use

ValidateFunc: validation.StringInSlice(autonomousdatabases.PossibleValuesForDataBaseType(), false),

ms-henglu · 2025-09-10T08:51:12Z

+	"github.com/hashicorp/go-azure-sdk/resource-manager/oracledatabase/2025-03-01/autonomousdatabases"
+)
+
+func DbSource(i interface{}, k string) (warnings []string, errors []error) {


Please remove this file as these validate functions are not used.

ms-henglu · 2025-09-10T08:56:58Z

+## Example Usage
+
+```hcl
+resource "azurerm_oracle_autonomous_database_cross_region_disaster_recovery" "example" {


Please add a complete configuration as an example.

Still needs complete example, resource dependencies such as the resource group, virtual network, etc. must be added.

See Provider Documentation Standards - Examples

ms-henglu · 2025-09-10T09:01:29Z

+
+* `location` - (Required) The Azure Region where the Cross Region Disaster Recovery Autonomous Database should exist. Azure Region must be different from region where your original Autonomous Database resides. Changing this forces a new Cross Region Disaster Recovery Autonomous Database to be created.
+
+* `database_type` - (Required) The type of Autonomous Database. To create Cross Region Disaster Recovery Autonomous Database set this value to "CrossRegionDisasterRecovery".


For the properties that are marked as "ForceNew". Please add "Changing this forces a new resource to be created." to the description.

Please also check:
name
database_type
source
remote_disaster_recovery_type
admin_password
backup_retention_period_in_days
character_set
compute_model
db_version
db_workload
display_name
mtls_connection_required
license_model
national_character_set
subnet_id
virtual_network_id
customer_contacts

mihretkidane-OCI · 2025-09-17T15:40:23Z

@ms-henglu can you please check this PR.

ms-henglu

LGTM

mihretkidane-OCI · 2025-09-25T15:09:39Z

@catriona-m I see @ms-henglu has approved it , could you also please review the PR. Thank you.

sreallymatt

Hi @evgeniifedotov, this will need a bit of work before it can be merged into the provider.

Could you first review my comment in website/docs/r/oracle_autonomous_database_cross_region_disaster_recovery.html.markdown regarding the design of this resource? (here)

sreallymatt · 2025-09-30T20:53:01Z

@@ -0,0 +1,535 @@
+// Copyright © 2025, Oracle and/or its affiliates. All rights reserved


Suggested change

// Copyright © 2025, Oracle and/or its affiliates. All rights reserved

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

sreallymatt · 2025-09-30T20:53:13Z

+			Type:     pluginsdk.TypeString,
+			Computed: true,
+		},
+		"source_id": {


Based on the resource test this looks like the id to an autonomous database, can you update this to be more specific as to what it is?

Suggested change

"source_id": {

"source_autonomous_database_id": {

sreallymatt · 2025-09-30T20:53:17Z

+		},
+
+		// AutonomousDatabaseProperties
+		"actual_used_data_storage_size_in_tbs": {


Suggested change

"actual_used_data_storage_size_in_tbs": {

"actual_used_data_storage_size_in_tb": {

sreallymatt · 2025-09-30T20:53:18Z

+			Computed: true,
+		},
+
+		"allocated_storage_size_in_tbs": {


Suggested change

"allocated_storage_size_in_tbs": {

"allocated_storage_size_in_tb": {

sreallymatt · 2025-09-30T20:53:24Z

+		"autonomous_database_id": {
+			Type:     pluginsdk.TypeString,
+			Computed: true,
+		},


Is this not the same as the id attribute for this datasource?

Please see #29633 (comment)

sreallymatt · 2025-09-30T21:12:34Z

+
+## Import
+
+Cross Region Disaster Recovery Autonomous Database cannot be imported. `admin_password` parameter is required, but this parameter cannot be imported, therefore the entire import procedure cannot be executed.


We have many resources that have password properties that aren't returned by the API. Generally users will just have to set ignore_changes on the properties that aren't imported, or we implement custom import logic.

Resources can always be imported.

sreallymatt · 2025-09-30T21:12:47Z

+## Update
+
+Cross Region Disaster Recovery Autonomous Database cannot be updated as is must have exactly same parameters as peered original Autonomous Database. Updating original Autonomous Database will trigger an update for peered Cross Region Disaster Recovery Autonomous Database.


This isn't a heading we include in our docs, please remove.

Additionally, "Cross Region Disaster Recovery Autonomous Database cannot be updated as is must have exactly same parameters as peered original Autonomous Database" doesn't make sense since you have added an update function to this resource?

It sounds like this probably shouldn't have an update function?

sreallymatt · 2025-09-30T21:14:16Z

+	NextLongTermBackupTimeStamp             string   `tfschema:"next_long_term_backup_time_stamp"`
+	Ocid                                    string   `tfschema:"ocid"`
+	OciUrl                                  string   `tfschema:"oci_url"`
+	PeerDbId                                string   `tfschema:"peer_db_id"`


In #29633, it was brought up that peer_db_id is not actually returned, so there's no sense in exposing it?

Pleas remove any other attributes that don't return a value, always return a single value, or always return empty values (e.g. empty arrays as mentioned in the docs for supported_regions_to_clone_to)

sreallymatt · 2025-09-30T21:14:37Z

+			Computed: true,
+		},
+
+		"peer_db_id": {


Since this is not returned there's no need to expose it

sreallymatt · 2025-09-30T21:15:42Z

+			Optional: true,
+			Computed: true,


Please add a note as to why this must be optional+computed (ref)

mihretkidane-OCI · 2025-10-24T15:47:03Z

New tests

ms-zhenhua · 2026-01-26T08:36:36Z

+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0


Suggested change

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

// Copyright IBM Corp. 2014, 2025

// SPDX-License-Identifier: MPL-2.0

ms-zhenhua · 2026-01-26T08:36:49Z

+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0


Suggested change

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

// Copyright IBM Corp. 2014, 2025

// SPDX-License-Identifier: MPL-2.0

ms-zhenhua · 2026-01-26T08:36:59Z

+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0


Suggested change

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

// Copyright IBM Corp. 2014, 2025

// SPDX-License-Identifier: MPL-2.0

ms-zhenhua · 2026-01-26T08:37:07Z

+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0


Suggested change

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

// Copyright IBM Corp. 2014, 2025

// SPDX-License-Identifier: MPL-2.0

ms-zhenhua · 2026-01-26T08:39:04Z

+  auto_scaling_enabled             = false
+  auto_scaling_for_storage_enabled = false
+  mtls_connection_required         = false
+  data_storage_size_in_tbs         = 1


Can the testcase pass?

Suggested change

data_storage_size_in_tbs = 1

data_storage_size_in_tb = 1

@ms-zhenhua in this part the parameter is passed to the oracle_autonomous_database_resource_test.go to create the primary database , in our legacy code that's how its written with an 's' check it here

ms-zhenhua · 2026-01-27T02:34:07Z

+* `private_endpoint_url` - The private endpoint for the resource.
+
+* `private_endpoint_label` - The private endpoint label for the resource.


Suggested change

* `private_endpoint_url` - The private endpoint for the resource.

* `private_endpoint_label` - The private endpoint label for the resource.

* `private_endpoint_label` - The private endpoint label for the resource.

* `private_endpoint_url` - The private endpoint for the resource.

ms-zhenhua · 2026-01-27T02:38:28Z

+			if sourceDb.Model == nil {
+				return fmt.Errorf("retrieving %s: `Model` was nil", sourceId)
+			}
+			sourceLocation := sourceDb.Model.Location


this comment is not resolved.

ms-zhenhua · 2026-01-27T02:51:40Z

+* `resource_group_name` - (Required) The name of the Resource Group where the resource should exist. Changing this forces a new resource to be created.
+
+* `name` - (Required) The name for this Cross Region Disaster Recovery Autonomous Database. Changing this forces a new resource to be created.


Suggested change

* `resource_group_name` - (Required) The name of the Resource Group where the resource should exist. Changing this forces a new resource to be created.

* `name` - (Required) The name for this Cross Region Disaster Recovery Autonomous Database. Changing this forces a new resource to be created.

* `name` - (Required) The name for this Cross Region Disaster Recovery Autonomous Database. Changing this forces a new resource to be created.

* `resource_group_name` - (Required) The name of the Resource Group where the resource should exist. Changing this forces a new resource to be created.

ms-zhenhua · 2026-01-27T02:57:57Z

+
+Use this data source to access information about an existing peered Cross Region Disaster Recovery Autonomous Database.
+
+## Example Usage


According to the guidance, all name arguments should be example or be prefixed with example-. Please update all name related arguments in the configuration.

ms-zhenhua · 2026-01-27T02:58:10Z

+Manages a Cross Region Disaster Recovery Autonomous Database.
+A Cross Region Disaster Recovery Autonomous Database is an Autonomous Database with a specific Cross-Region Disaster Recovery role. It must be an exact copy of the Autonomous Database for which you want to create a Disaster Recovery instance. The Cross Region Disaster Recovery Autonomous Database must reside in a region that is different from the region of the main Autonomous Database. You must create a separate virtual network and subnet in this second region for the Cross Region Disaster Recovery Autonomous Database to be able to communicate with its original database.
+
+## Example Usage


According to the guidance, all name arguments should be example or be prefixed with example-. Please update all name related arguments in the configuration.

…BS-Cross-Region_Disaster-Recovery

mihretkidane-OCI

@ms-zhenhua thank you , I have replied and addressed your latest comments.

ms-zhenhua · 2026-01-30T01:49:35Z

+				return fmt.Errorf("retrieving %s: `Model` was nil", sourceId)
+			}
+			sourceLocation := location.Normalize(sourceDb.Model.Location)
+			if location.Normalize(model.Location) == location.Normalize(sourceLocation) {


Suggested change

if location.Normalize(model.Location) == location.Normalize(sourceLocation) {

normalizedLocation = location.Normalize(model.Location)

if normalizedLocation == sourceLocation {

ms-zhenhua · 2026-01-30T05:45:24Z

+
+			param := autonomousdatabases.AutonomousDatabase{
+				Name:     pointer.To(model.Name),
+				Location: location.Normalize(model.Location),


Suggested change

Location: location.Normalize(model.Location),

Location: normalizedLocation,

ms-zhenhua · 2026-01-30T05:47:41Z

+			if err != nil {
+				return err
+			}
+			VnetId := commonids.NewVirtualNetworkID(subnetId.SubscriptionId, subnetId.ResourceGroupName, subnetId.VirtualNetworkName)


Suggested change

VnetId := commonids.NewVirtualNetworkID(subnetId.SubscriptionId, subnetId.ResourceGroupName, subnetId.VirtualNetworkName)

vnetId := commonids.NewVirtualNetworkID(subnetId.SubscriptionId, subnetId.ResourceGroupName, subnetId.VirtualNetworkName)

ms-zhenhua · 2026-01-30T05:54:24Z

+				return fmt.Errorf("retrieving %s: %+v", sourceId, err)
+			}
+			if sourceDb.Model == nil {
+				return fmt.Errorf("retrieving %s: `Model` was nil", sourceId)


Suggested change

return fmt.Errorf("retrieving %s: `Model` was nil", sourceId)

return fmt.Errorf("retrieving %s: `model` was nil", sourceId)

ms-zhenhua · 2026-01-30T05:54:36Z

+			VnetId := commonids.NewVirtualNetworkID(subnetId.SubscriptionId, subnetId.ResourceGroupName, subnetId.VirtualNetworkName)
+
+			if sourceDb.Model.Properties == nil {
+				return fmt.Errorf("retrieving %s: `Properties` was nil", sourceId)


Suggested change

return fmt.Errorf("retrieving %s: `Properties` was nil", sourceId)

return fmt.Errorf("retrieving %s: `properties` was nil", sourceId)

ms-zhenhua · 2026-01-30T08:18:18Z

+}
+
+resource "azurerm_subnet" "example_subnet" {
+  name                 = "exampleSubnet"


Suggested change

name = "exampleSubnet"

name = "example-subnet"

ms-zhenhua · 2026-01-30T08:18:30Z

+
+
+resource "azurerm_oracle_autonomous_database" "primary" {
+  name                             = "examplePrimary"


Suggested change

name = "examplePrimary"

name = "example-primary"

ms-zhenhua · 2026-01-30T08:18:47Z

+}
+
+resource "azurerm_virtual_network" "dr_vnet" {
+  name                = "exampleDrVnet"


Suggested change

name = "exampleDrVnet"

name = "example-dr-vnet"

ms-zhenhua · 2026-01-30T08:19:04Z

+}
+
+resource "azurerm_subnet" "dr_subnet" {
+  name                 = "exampleDrSubnet"


Suggested change

name = "exampleDrSubnet"

name = "example-dr-subnet"

ms-zhenhua · 2026-01-30T08:19:18Z

+}
+
+resource "azurerm_oracle_autonomous_database_cross_region_disaster_recovery" "dr_example" {
+  name                                = "exampleDr"


Suggested change

name = "exampleDr"

name = "example-dr"

…BS-Cross-Region_Disaster-Recovery

mihretkidane-OCI · 2026-02-11T21:42:25Z

…BS-Cross-Region_Disaster-Recovery

mihretkidane-OCI

@ms-zhenhua I have updated the PR with new test and resolved last comments please take a look. Thanks!

mihretkidane-OCI · 2026-02-13T15:38:58Z

@sreallymatt could you please one more review to this PR. Thanks!

ms-zhenhua · 2026-02-25T06:32:47Z

+}
+
+
+resource "azurerm_oracle_autonomous_database" "primary" {


Suggested change

}

resource "azurerm_oracle_autonomous_database" "primary" {

}

resource "azurerm_oracle_autonomous_database" "primary" {

…BS-Cross-Region_Disaster-Recovery

ms-zhenhua · 2026-04-27T09:36:49Z

+  replicate_automatic_backups_enabled = false
+
+}
+`, a.template(data), data.RandomInteger, "eastus", "westus")


Is there any reason that not use data.Locations.Primary but use const strings of "eastus", "westus" as the location?

…BS-Cross-Region_Disaster-Recovery

mihretkidane-OCI · 2026-05-11T15:31:54Z

@ms-zhenhua can you check the PR , I have updated to use location.primary and location.secondary . I have validated the PR as well see screenshots.

ms-zhenhua · 2026-05-13T08:19:58Z

@mihretkidane-OCI ,

there are still many comments not resolved. Could you double check the existing comments and resolve them all?

evgeniifedotov requested a review from a team as a code owner July 16, 2025 22:45

github-actions Bot added documentation size/XL labels Jul 16, 2025

github-actions Bot added the waiting-response label Jul 31, 2025

catriona-m requested changes Jul 31, 2025

View reviewed changes

evgenwk requested review from WodansSon and magodo as code owners August 5, 2025 13:22

github-actions Bot removed the waiting-response label Aug 5, 2025

catriona-m requested changes Aug 6, 2025

View reviewed changes

rcskosir added the new-resource label Aug 6, 2025

evgenwk force-pushed the efedotov/2025-03-01-Terraform-AzureRM-for-ADBS-Cross-Region_Disaster-Recovery branch 2 times, most recently from ca3ab38 to 695f4b9 Compare August 7, 2025 15:12

evgenwk force-pushed the efedotov/2025-03-01-Terraform-AzureRM-for-ADBS-Cross-Region_Disaster-Recovery branch from 695f4b9 to 1ef44e2 Compare August 7, 2025 18:50

evgeniifedotov requested a review from catriona-m August 11, 2025 20:10

mybayern1974 assigned ms-henglu Aug 15, 2025

ms-henglu suggested changes Aug 25, 2025

View reviewed changes

evgenwk force-pushed the efedotov/2025-03-01-Terraform-AzureRM-for-ADBS-Cross-Region_Disaster-Recovery branch from 91842ea to 17062ad Compare September 5, 2025 15:13

ms-henglu suggested changes Sep 10, 2025

View reviewed changes

ms-henglu approved these changes Sep 25, 2025

View reviewed changes

sreallymatt requested changes Sep 30, 2025

View reviewed changes

github-actions Bot assigned sreallymatt Sep 30, 2025

github-actions Bot added the waiting-response label Sep 30, 2025

evgenwk force-pushed the efedotov/2025-03-01-Terraform-AzureRM-for-ADBS-Cross-Region_Disaster-Recovery branch from 89810c0 to d9a7f6d Compare October 23, 2025 17:58

github-actions Bot removed the waiting-response label Oct 23, 2025

ms-zhenhua suggested changes Jan 27, 2026

View reviewed changes

evgenwk added 2 commits January 28, 2026 13:39

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

aa28dae

…BS-Cross-Region_Disaster-Recovery

Oracle code fixed - update code after review

dfee32b

mihretkidane-OCI reviewed Jan 28, 2026

View reviewed changes

ms-zhenhua suggested changes Jan 30, 2026

View reviewed changes

evgenwk added 3 commits February 3, 2026 11:58

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

b7b0c69

…BS-Cross-Region_Disaster-Recovery

Oracle code fixed - update code after review

63f98ca

Fix code style

21ee0a3

evgenwk added 3 commits February 11, 2026 16:47

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

9c270c4

…BS-Cross-Region_Disaster-Recovery

Oracle - remove fields in the documentation

5e48d23

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

c98cd6a

…BS-Cross-Region_Disaster-Recovery

mihretkidane-OCI reviewed Feb 12, 2026

View reviewed changes

mihretkidane-OCI mentioned this pull request Feb 24, 2026

update vmCluster resource to allow updatable values through OCI #31818

Closed

15 tasks

ms-zhenhua suggested changes Feb 25, 2026

View reviewed changes

evgenwk added 5 commits February 25, 2026 12:21

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

a05b426

…BS-Cross-Region_Disaster-Recovery

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

80c8e4a

…BS-Cross-Region_Disaster-Recovery

Oracle - update autonomous_database_cross_region_disaster_recovery

1de8261

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

3b3723a

…BS-Cross-Region_Disaster-Recovery

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

fb11058

…BS-Cross-Region_Disaster-Recovery

ms-zhenhua suggested changes Apr 27, 2026

View reviewed changes

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

1f946ce

…BS-Cross-Region_Disaster-Recovery

katbyte added the allow-without-list label May 4, 2026

evgenwk added 3 commits May 7, 2026 10:50

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

92d4345

…BS-Cross-Region_Disaster-Recovery

Oracle - update autonomous_database_cross_region_disaster_recovery

64284db

Merge branch 'main' into efedotov/2025-03-01-Terraform-AzureRM-for-AD…

1fe038b

…BS-Cross-Region_Disaster-Recovery

hjkhkashkdsa

c7d6139


		* `location` - (Required) The Azure Region where the Cross Region Disaster Recovery Autonomous Database should exist. Azure Region must be different from region where your original Autonomous Database resides. Changing this forces a new Cross Region Disaster Recovery Autonomous Database to be created.

		* `database_type` - (Required) The type of Autonomous Database. To create Cross Region Disaster Recovery Autonomous Database set this value to "CrossRegionDisasterRecovery".

		@@ -0,0 +1,535 @@
		// Copyright © 2025, Oracle and/or its affiliates. All rights reserved

	// Copyright © 2025, Oracle and/or its affiliates. All rights reserved
	// Copyright (c) HashiCorp, Inc.
	// SPDX-License-Identifier: MPL-2.0

	"actual_used_data_storage_size_in_tbs": {
	"actual_used_data_storage_size_in_tb": {

	"allocated_storage_size_in_tbs": {
	"allocated_storage_size_in_tb": {


		## Import

		Cross Region Disaster Recovery Autonomous Database cannot be imported. `admin_password` parameter is required, but this parameter cannot be imported, therefore the entire import procedure cannot be executed.

		## Update

		Cross Region Disaster Recovery Autonomous Database cannot be updated as is must have exactly same parameters as peered original Autonomous Database. Updating original Autonomous Database will trigger an update for peered Cross Region Disaster Recovery Autonomous Database.

		* `private_endpoint_url` - The private endpoint for the resource.

		* `private_endpoint_label` - The private endpoint label for the resource.

		* `resource_group_name` - (Required) The name of the Resource Group where the resource should exist. Changing this forces a new resource to be created.

		* `name` - (Required) The name for this Cross Region Disaster Recovery Autonomous Database. Changing this forces a new resource to be created.


		Use this data source to access information about an existing peered Cross Region Disaster Recovery Autonomous Database.

		## Example Usage

	if location.Normalize(model.Location) == location.Normalize(sourceLocation) {
	normalizedLocation = location.Normalize(model.Location)
	if normalizedLocation == sourceLocation {

	Location: location.Normalize(model.Location),
	Location: normalizedLocation,

	VnetId := commonids.NewVirtualNetworkID(subnetId.SubscriptionId, subnetId.ResourceGroupName, subnetId.VirtualNetworkName)
	vnetId := commonids.NewVirtualNetworkID(subnetId.SubscriptionId, subnetId.ResourceGroupName, subnetId.VirtualNetworkName)

	return fmt.Errorf("retrieving %s: `Model` was nil", sourceId)
	return fmt.Errorf("retrieving %s: `model` was nil", sourceId)

	return fmt.Errorf("retrieving %s: `Properties` was nil", sourceId)
	return fmt.Errorf("retrieving %s: `properties` was nil", sourceId)



		resource "azurerm_oracle_autonomous_database" "primary" {
		name = "examplePrimary"

Conversation

evgeniifedotov commented Jul 16, 2025

Community Note

Description

Attributes Reference

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

evgenwk commented Aug 7, 2025

Uh oh!

mihretkidane-OCI commented Aug 22, 2025

Uh oh!

ms-henglu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mihretkidane-OCI commented Sep 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mihretkidane-OCI commented Sep 17, 2025

Uh oh!

ms-henglu left a comment

Choose a reason for hiding this comment

Uh oh!

mihretkidane-OCI commented Sep 25, 2025

Uh oh!

sreallymatt left a comment •

edited

Loading

sreallymatt Sep 30, 2025 •

edited

Loading